I think it's perfectly reasonable for Halsin to be adamantly against being in the same camp as Minthara. God forbid a man who had a horrible experience with drow in the past (and still doesn't project it on all other drow, which is pretty telling given how being wary of drow is acceptable in Faerun) not to be able to trust someone who imprisoned him, tortured him and was very vocal on invading his home and killing his entire family.

So no, Halsin isn't "ruined" by that development. He has his boundaries too. When it's only he who is attacked physically or emotionally, he may brush it off and endure. But when it's people he feels responsible for, he won't back down.

Kind people aren't all-forgiving. They have their limits - and having the lives of people they care about threatened by an invader is such a limit.